tdf#49885 BreakIterator rule upgrades

This change re-bases the BreakIterator rule customizations on top of a
clean copy of the ICU 74.2 rules.

Change-Id: Iadcf16cab138cc6c869fac61ad64e996e65b5ae4
R

tdf#49885 BreakIterator rule upgrades

This change re-bases the BreakIterator rule customizations on top of a
clean copy of the ICU 74.2 rules.

Change-Id: Iadcf16cab138cc6c869fac61ad64e996e65b5ae4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166273
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

show more ...

makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo)

…by a simple/static $(gb_UnpackedTarball_workdir)/foo
see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f

Change-Id: I8e6aa55c8

makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo)

…by a simple/static $(gb_UnpackedTarball_workdir)/foo
see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f

Change-Id: I8e6aa55c85534c4446556548910c950ddbe7c6fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167163
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins

show more ...

makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo)

…by a simple/static $(gb_CustomTarget_workdir)/foo

The build system has a lot of overly complicated leftovers from when it
w

makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo)

…by a simple/static $(gb_CustomTarget_workdir)/foo

The build system has a lot of overly complicated leftovers from when it
was introduced and had not only deal with split repositories but also
had to coexist with another buildsystem. Along with lots of copy'n'paste
along the years the makefiles became hard to grasp for newcomers with
all our calls and evals.
As a first step to streamline that, the macros from TargetLocations that
simply prefix a static path to the argument (and similar of the same
kind) are a natural pick before simplifying the rules themselves/getting
rid of a bunch of eval statements.

Change-Id: Ia06dbbcd5d1994755a2ff05b84f72ccbc4e3cab5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167005
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

show more ...

tdf#49885 Updated CJK BreakIterator to use ICU

Previously, the CJK BreakIterator used custom dictionaries for Chinese
and Japanese. This change removes these custom dictionaries in favor of
the upst

tdf#49885 Updated CJK BreakIterator to use ICU

Previously, the CJK BreakIterator used custom dictionaries for Chinese
and Japanese. This change removes these custom dictionaries in favor of
the upstream ICU implementation, which uses an externally-maintained
frequency dictionary for these languages.

This change also removes support code for dictionary-based break
iterators, as it is no longer used.

Change-Id: I55c4ce9c842d1751997309fd7446e0a6917915dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166136
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

show more ...

fix a from-scratch i18npool build problem

genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/count_word.brk", "U_FILE_ACCESS_ERROR"
make[1]: *** [/mnt/i18npool/Cust

fix a from-scratch i18npool build problem

genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/count_word.brk", "U_FILE_ACCESS_ERROR"
make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/count_word.brk] Error 4
make[1]: *** Waiting for unfinished jobs....
genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/edit_word_he.brk", "U_FILE_ACCESS_ERROR"
make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/edit_word_he.brk] Error 4
genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_he.brk", "U_FILE_ACCESS_ERROR"
make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_he.brk] Error 4
genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_prepostdash.brk", "U_FILE_ACCESS_ERROR"
make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_prepostdash.brk] Error 4
genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_nodash.brk", "U_FILE_ACCESS_ERROR"
make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_nodash.brk] Error 4
genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_hu.brk", "U_FILE_ACCESS_ERROR"
make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_hu.brk] Error 4
genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word.brk", "U_FILE_ACCESS_ERROR"
make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word.brk] Error 4

probably since:

commit c276694bc06ae460a78532757db08e531b478e20
Date: Wed Jun 21 13:14:42 2023 +0300

Remove another workaround for old versions of ICU

Change-Id: I31f07900d46a042a50d1bbbdd889ef6cee6bed8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153538
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

show more ...

Remove another workaround for old versions of ICU

Change-Id: Id13bdb10bf4bf89a136b28a26c4b3d1113971871
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153388
Tested-by: Jenkins
Reviewed-by: خال

Remove another workaround for old versions of ICU

Change-Id: Id13bdb10bf4bf89a136b28a26c4b3d1113971871
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153388
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>

show more ...

gbuild: introduce plugin + loader concepts

This introduces two concepts: a plugin and its loader (library)

LO currrently has dependency cycles for some libraries. There is
scui, which depends on sc

gbuild: introduce plugin + loader concepts

This introduces two concepts: a plugin and its loader (library)

LO currrently has dependency cycles for some libraries. There is
scui, which depends on sc, while sc dlopen's scui. There are the
various vclplug_*, i18npool plugins, filters/gie, acc, etc.

Usually these plugins link to their loader library, because they
use its symbols. But as a result there is no sensible way to
express the runtime dependency of loaders on the plugins.

In GNU libtool plugins are called modules and they are implemented
in an IMHO more sensible way by allowing missing symbols at link
time. This way you can have a dependency from the loader library
to its plugins, as the plugins don't depend on the loader, but you
lose the link time detection of missing symbols.

While this is in theory possible in LO too, LO currently has
plugins, like acc (accessibility), loaded by tk (toolkit), which
depends on svt (svtools), which itself depends on tk, so dropping
the tk dependency for acc on its own doesn't help :-(

And while the dependency of the plugins on their loader is fine
for the shared / DYNLOADING build, for the "static" builds you
must (somehow) link the plugins into the executables.

I also codeified a few rules into the build system along with it:
* just plugins are allowed to depend / link other plugins
* plugins aren't allowed to be linked into the merge lib
* plugin loaders are "limited" to libraries

At the high level, this is implemented via new gbuild calls:
* gb_Library_set_plugin_for,lib,loader: declare a library to be a
plugin of a loader library and add a dependeny from the plugin
library to the loader library
* gb_Library_set_plugin_for_nodep,lib,loader: ^^^^ without adding
the library dependeny
* gb_Helper_register_plugins_for_install: "plugin" replacement for
gb_Helper_register_libraries_for_install to implement some
additional checks in the build system

In the end this patch just adds a bit syntactic sugar and nothing
changes for any build.

Change-Id: I7b01d9c384cbc5838bd2cc93aff18e4868939d6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126163
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

show more ...

drop custom Indic grapheme rules and rely on contemporary icu defaults

similar to...

commit 8578a1c9d167c19f1d8038fac5946b4b3cae305e
Date: Thu Nov 26 15:47:26 2020 +0200

tdf#138481: Trust th

drop custom Indic grapheme rules and rely on contemporary icu defaults

similar to...

commit 8578a1c9d167c19f1d8038fac5946b4b3cae305e
Date: Thu Nov 26 15:47:26 2020 +0200

tdf#138481: Trust the built-in break iterator character data in ICU

Don't use our own char.txt.

the char_in.txt hasn't really changed since 2008 and is woefully out of
date at this point.

we have cppunit tests for the only documented bug that touched
char_in.txt, #i111152# and tdf#40292, for tdf#40292 change the test
to test what was actually reported as a bug

Change-Id: I8e35b102b0a46d2c63e47e055e472892f65022ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106763
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

show more ...

tdf#138481: Trust the built-in break iterator character data in ICU

Don't use our own char.txt.

Quite possibly we wouldn't need to use the other data in the
i18npool/source/breakiterator/data folde

tdf#138481: Trust the built-in break iterator character data in ICU

Don't use our own char.txt.

Quite possibly we wouldn't need to use the other data in the
i18npool/source/breakiterator/data folder either. See the README file
there for the sad details.

Change-Id: I82923ae76407fdd3fa3642d818d43427fe4f5591
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106632
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

show more ...

GBUILD_TRACE, support for finding out where the build time is spent

See instructions in solenv/gbuild/Trace.mk . This generates a file than
can be viewed e.g. in the Chromium tracing view.

Change-I

GBUILD_TRACE, support for finding out where the build time is spent

See instructions in solenv/gbuild/Trace.mk . This generates a file than
can be viewed e.g. in the Chromium tracing view.

Change-Id: I5f90647c58ca729375525b6daed2d4918adc8188
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88754
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

show more ...

tdf#124536 android: fix breakiterator mismatch (separate data files for zh/ja)

There was a mismatch between the define DICT_JA_ZH_IN_DATAFILE (which
is effectively set for android as well via DISABL

tdf#124536 android: fix breakiterator mismatch (separate data files for zh/ja)

There was a mismatch between the define DICT_JA_ZH_IN_DATAFILE (which
is effectively set for android as well via DISABLE_DYNLOADING in
i18npool/Library_i18npool.mk and the makefile rules to actually compile
the data files and set the DICT_JA_ZH_IN_DATAFILE define in other places
that were guarded by checks for iOS.

Change-Id: Ia0f117220ab3bad92093a3bf6c613aa9c4812ed4
Reviewed-on: https://gerrit.libreoffice.org/83102
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

show more ...

gbuild: rename value OS=IOS to OS=iOS

This gets rid of the horrible hack in gbuild.mk to accomodate the
case-incorrect iOS platform makefiles that cannot be renamed without
upsetting git on file sys

gbuild: rename value OS=IOS to OS=iOS

This gets rid of the horrible hack in gbuild.mk to accomodate the
case-incorrect iOS platform makefiles that cannot be renamed without
upsetting git on file systems that sadly lack the case sensitivity
feature.

Keep the macro defined to IOS though.

Change-Id: I1022bfef4900da00e75fc1ccce786b20f8673234
Reviewed-on: https://gerrit.libreoffice.org/62705
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>

show more ...

i18npool: MSVC: pragma warning: make more specific, remove obsolete

Change-Id: Iacb0c1fba331aa76ea341bc21690f09109b14a0a
Reviewed-on: https://gerrit.libreoffice.org/48990
Tested-by: Jenkins <ci@libr

i18npool: MSVC: pragma warning: make more specific, remove obsolete

Change-Id: Iacb0c1fba331aa76ea341bc21690f09109b14a0a
Reviewed-on: https://gerrit.libreoffice.org/48990
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

show more ...

Use genbrk -i data include directory only if not SYSTEM_ICU

Change-Id: I8dc2f9a6ac2ad1ceec2d5e77ff547f929fa32861

icu genbrk built with enable-static can't find its data, help it out

Change-Id: I4e584a2d518d8d9a1e183cf4f5f76eaff349352d
Reviewed-on: https://gerrit.libreoffice.org/32095
Tested-by: Jenkins <ci@lib

icu genbrk built with enable-static can't find its data, help it out

Change-Id: I4e584a2d518d8d9a1e183cf4f5f76eaff349352d
Reviewed-on: https://gerrit.libreoffice.org/32095
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

show more ...

tdf#70833: IDNA support when exporing hyperlinks to PDF

Any URLs using non-ASCII IDNA syntax need to be resolved to ASCII-only, as PDF
URI Action's URI needs to be "encoded in 7-bit ASCII."

Introdu

tdf#70833: IDNA support when exporing hyperlinks to PDF

Any URLs using non-ASCII IDNA syntax need to be resolved to ASCII-only, as PDF
URI Action's URI needs to be "encoded in 7-bit ASCII."

Introduce URIHelper::resolveIdnaHost (svl/urihelper.hxx), which internally uses
icu::IDNA, which requires to bump the minimal --with-system-icu requirement from
4.2 to 4.6, which means ICU_RECLASSIFIED_CLOSE_PARENTHESIS is always true now.

Change-Id: I0e20d9a20ed2b869fba0cc7c969721411db590b3
Reviewed-on: https://gerrit.libreoffice.org/19669
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

show more ...

Resolves: fdo#55707 Word count incorrect if language is set to Finnish

Change-Id: I283dddaa4bd8baf05b90ce5f81d43b785021a3c4

Filter out extra ICU data for locales we don't want special support for

Change-Id: I40fd00d91a7e5ad5163bef63e1b60381bac58aa4

Put the dict_ja and _zh data in files instead of code for iOS

Map the file(s) into memory on demand. The executable file of an app
needs to be as small as possible. Including additional data files i

Put the dict_ja and _zh data in files instead of code for iOS

Map the file(s) into memory on demand. The executable file of an app
needs to be as small as possible. Including additional data files in
an app bundle is fine.

Change-Id: Ife9bfe99a2cf0473d459f38f50dfa3304b39e282

show more ...

normalize values of ICU_RECLASSIFIED_*

Change-Id: I1033676fe91062b1d364a458a5964cfb78f323f0

Move to MPLv2 license headers, with ESC decision and author's permission.

make it possible to build with system icu 4.2 (RHEL-6)

Change-Id: I69bf7bc33a619c4aa9483e2dc3d5540e4dfa7458

partly revert 92a9b7780c6e13a4da3b12794342edbc4c09ef51 for ICU < 49

Re-enable build with ICU 4.6 and 4.8
ICU versions prior to 49 don't know Conditional_Japanese_Starter and
Hebrew_Letter

Also, the

partly revert 92a9b7780c6e13a4da3b12794342edbc4c09ef51 for ICU < 49

Re-enable build with ICU 4.6 and 4.8
ICU versions prior to 49 don't know Conditional_Japanese_Starter and
Hebrew_Letter

Also, the change in i18npool/CustomTarget_breakiterator.mk

- -e "s#\[:LineBreak = Close_Punctuation:\]#\[& \[:LineBreak = Close_Parenthesis:\]\]#" \

with i18npool/source/breakiterator/data/line.txt

-$CL = [:LineBreak = Close_Punctuation:] ;
+$CL = [:LineBreak = Close_Parenthesis:];

did not produce equivalent results. Instead use

$CP = [:LineBreak = Close_Parenthesis:];
$CL = [[:LineBreak = Close_Punctuation:] $CP];

Change-Id: I14fc14319ea34f23393264560452a79bb49fc3a7

show more ...

add runtime deps for custom targets

Change-Id: I49272003ea72c84c9e81bc826820b0ac5f9d5008

follow logical consequences of a minimum icu version of 4.6

since commit f20ed8959bc0a984177377a734d34f767653625b

Change-Id: I4f2fc5d9eb7a581b9ed707a3c3f96be817141846